Skip to content

Commit

Permalink
ci: Update all instances of pull_request to pull_request_target in pr…
Browse files Browse the repository at this point in the history
…esubmit workflow (#1408)

After changing just the triggering event, nothing is checked out due to these defensive checks not being updated.
  • Loading branch information
melink14 authored Feb 13, 2023
1 parent c15ca7c commit 765d9db
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- uses: actions/checkout@v3.3.0
if: github.event_name == 'push'
- uses: actions/checkout@v3.3.0
if: github.event_name == 'pull_request'
if: github.event_name == 'pull_request_target'
with:
repository: ${{ github.event.pull_request.head.repo.full_name }}
ref: ${{ github.event.pull_request.head.ref }}
Expand Down Expand Up @@ -51,21 +51,21 @@ jobs:
path: screenshots/Chromium/failed/
- name: Update baseline screenshots
run: npm run test:update-baselines
if: failure() && steps.check-screenshots.outputs.screenshot_failure > 0 && github.event_name == 'pull_request'
if: failure() && steps.check-screenshots.outputs.screenshot_failure > 0 && github.event_name == 'pull_request_target'
- name: Push new baselines to pull request branch
uses: EndBug/add-and-commit@v9.1.1
if: failure() && steps.check-screenshots.outputs.screenshot_failure > 0 && github.event_name == 'pull_request'
if: failure() && steps.check-screenshots.outputs.screenshot_failure > 0 && github.event_name == 'pull_request_target'
with:
message: 'test(visual): Update baselines with new screenshots'
fetch: false
add: 'screenshots/Chromium/baseline/*.png'
default_author: github_actions
- name: Try to fix lint errors
run: npm run fix
if: failure() && github.event_name == 'pull_request'
if: failure() && github.event_name == 'pull_request_target'
- name: Push lint fixes to pull request branch
uses: EndBug/add-and-commit@v9.1.1
if: failure() && github.event_name == 'pull_request'
if: failure() && github.event_name == 'pull_request_target'
with:
message: 'style: Fix lint/formatting errors'
fetch: false
Expand Down

0 comments on commit 765d9db

Please sign in to comment.