This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
Hello result information! #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge Titan upstream into your fork
… for better logging
mellowagain
suggested changes
Feb 24, 2018
Titan/Properties/AssemblyInfo.cs
Outdated
| @@ -18,6 +18,6 @@ | |||
| // Titan uses SemVer (Microsoft doesn't prefer that and displays a warning), thats why we disable the compiler warnings. | |||
| [assembly: AssemblyVersion("1.6.0")] | |||
| [assembly: AssemblyFileVersion("1.6.0")] | |||
| [assembly: AssemblyInformationalVersion("1.6.0-<%GitHash%>")] // Will be edited by Cake Build Script | |||
| [assembly: AssemblyInformationalVersion("1.6.0-e7b1319")] // Will be edited by Cake Build Script | |||
There was a problem hiding this comment.
Please revert this back to <%GitHash%>.
TitanTest/Properties/AssemblyInfo.cs
Outdated
| @@ -19,6 +19,6 @@ | |||
| // TitanTest uses SemVer (Microsoft doesn't prefer that and displays a warning), thats why we disable the compiler warnings. | |||
| [assembly: AssemblyVersion("1.6.0")] | |||
| [assembly: AssemblyFileVersion("1.6.0")] | |||
| [assembly: AssemblyInformationalVersion("1.6.0-<%GitHash%>")] // Will be edited by Cake Build Script | |||
| [assembly: AssemblyInformationalVersion("1.6.0-e7b1319")] // Will be edited by Cake Build Script | |||
There was a problem hiding this comment.
Please revert this back to <%GitHash%>.
Titan/Managers/ThreadManager.cs
Outdated
| @@ -229,7 +246,8 @@ public void StartCommend(TitanAccount account, CommendInfo info) | |||
| var timeSpent = DateTime.Now.Subtract(account.StartEpoch.ToDateTime()); | |||
|
|
|||
| _log.Error("Connection to account {Account} timed out. It was not possible to " + | |||
| "commend the target after {Timespan} seconds.", account.JsonAccount.Username, timeSpent.Seconds); | |||
| "commend the target after {Timespan} seconds.", account.JsonAccount.Username, | |||
| timeSpent.Seconds); | |||
| @@ -302,7 +320,8 @@ public void StartMatchResolving(TitanAccount account, LiveGameInfo info) | |||
| var timeSpent = DateTime.Now.Subtract(account.StartEpoch.ToDateTime()); | |||
|
|
|||
| _log.Error("Connection to account {Account} timed out. It was not possible to resolve the Match " + | |||
| "ID for the target after {Timespan} seconds.", account.JsonAccount.Username, timeSpent.Seconds); | |||
| "ID for the target after {Timespan} seconds.", account.JsonAccount.Username, | |||
| timeSpent.Seconds); | |||
There was a problem hiding this comment.
Yes, the value will be edited by the Cake Build Script but is supposted to be reverted back after the build process finished. It seems you cancelled the build process mid-way.
Also, please follow the Contributor Covenant Code of Conduct before discussing and contributing to the Titan repository and the issues section. Inappropriate language may result in you losing your Collaborator permissions.
mellowagain
added
type: patch
status: needs changes
and removed
status: high priority
labels
mellowagain
approved these changes
Feb 24, 2018
raspbianlike
added a commit
to raspbianlike/Titan
that referenced
this pull request
Feb 25, 2018
raspbianlike
added a commit
to raspbianlike/Titan
that referenced
this pull request
Feb 25, 2018
raspbianlike
added a commit
to raspbianlike/Titan
that referenced
this pull request
Feb 25, 2018
This reverts commit db6ad80.
4 tasks
mellowagain
pushed a commit
that referenced
this pull request
Feb 25, 2018
* Fix printing issues + handle default case in report / commend session for better logging * Maybe this looks better as an error? * Fix formatting? :niggerthink: * GitHash? * GitHash? v2 * Hotfix for #86 * Hotfix for #86 * Revert "Hotfix for #86" This reverts commit db6ad80. * This formatting is getting annoying
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your pull request here
Type
Checklist
Check the checkbox(es) that apply.
./build.shis passing with every build step and every test locally.Discussion
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
Reviewers
@Marc3842h, ...