Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for dired-list #8424

Merged
merged 1 commit into from
Mar 12, 2023
Merged

Add recipe for dired-list #8424

merged 1 commit into from
Mar 12, 2023

Conversation

Fuco1
Copy link
Contributor

@Fuco1 Fuco1 commented Mar 3, 2023

Brief summary of what the package does

Produce a file listing with a shell incantation and make a dired
out of it!

Direct link to the package repository

https://github.com/Fuco1/dired-hacks

Your association with the package

Author

Relevant communications with the upstream package maintainer

None needed

Checklist

@riscy
Copy link
Member

riscy commented Mar 5, 2023

Thanks for this. Quick first pass --

dired-list.el with byte-compile using Emacs 28.1:

dired-list.el:65:1: Error: Cannot open load file: No such file or directory, dired-hacks-utils

dired-list.el with checkdoc 0.6.2:

dired-list.el:49: Name emacs should appear capitalized as Emacs
dired-list.el:71: Flag variable doc strings should usually start: Non-nil means
dired-list.el:284: Argument `dir' should appear (as DIR) in the doc string
dired-list.el:330: Argument `cmd' should appear (as CMD) in the doc string

dired-list.el with melpazoid:

- dired-list.el#L295: There is no need to quote lambdas (neither #' nor ')
- dired-list.el#L315: There is no need to quote lambdas (neither #' nor ')

#'load-check on each file:

Loading dired-list.el
  dired-list.el:Error: Emacs 28.1:
  (file-missing "Cannot open load file" "No such file or directory" "dired-hacks-utils")

Package and license:

  • Prefer the default recipe or :defaults, if possible.
  • Add a LICENSE file to the repository

@Fuco1
Copy link
Contributor Author

Fuco1 commented Mar 6, 2023

I don't know what this is: Prefer the default recipe or :defaults, if possible.

@riscy
Copy link
Member

riscy commented Mar 12, 2023

Apologies for that - the default recipe shouldn't apply in this case. (That lint means no :files specifier or :defaults in the files list).

Looks good to go!

@riscy riscy merged commit 5f202ac into melpa:master Mar 12, 2023
mhayashi1120 pushed a commit to mhayashi1120/melpa that referenced this pull request Apr 5, 2023
akirak pushed a commit to akirak/melpa that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants