-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add raise_error option to run and run_and_log methods in process.py #206
Open
nivinsrinivas
wants to merge
11
commits into
meltano:main
Choose a base branch
from
nivinsrinivas:chore/add_raise_error_to_run_and_log
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2666eae
Add raise_error option to run and run_and_log methods in process.py
nivinsrinivas ad9f9d7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4a47352
Fix missing delimiter in return
nivinsrinivas 7800d63
Removed raise_error in _exec method
nivinsrinivas 96bf2a7
flake8 fixes
nivinsrinivas 52495f8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 10f38ce
Else block for raise_error=False
nivinsrinivas d346076
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cb6f219
Merge branch 'meltano:main' into chore/add_raise_error_to_run_and_log
nivinsrinivas 2001bc7
Merge branch 'main' into chore/add_raise_error_to_run_and_log
edgarrmondragon a64d8e6
Merge branch 'main' into chore/add_raise_error_to_run_and_log
edgarrmondragon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm if
raise_error
isn't doing anything at the moment?Perhaps the same argument name
check
should be used for this method and just pass it directly tosubprocess.run(..., check=check)
.