Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tap-csv encoding option #758

Merged
merged 2 commits into from
Sep 1, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions _data/meltano/extractors/tap-csv/meltanolabs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,26 +18,26 @@ settings:
label: Files
kind: array
description: |
Array of objects with `entity`, `path`, and `keys` keys:
Array of objects with `entity`, `path`, `keys`, and `encoding` [Optioanl] keys:

* `entity`: The entity name, used as the table name for the data loaded from that CSV.
* `path`: Local path (relative to the project's root) to the file to be ingested. Note that this may be a directory, in which case all files in that directory and any of its subdirectories will be recursively processed
* `keys`: The names of the columns that constitute the unique keys for that entity.

Each input CSV file must be a traditionally-delimited CSV (comma separated columns, newlines indicate new rows, double quoted values).
* `encoding`: [Optional] The file encoding to use when reading the file (i.e. "latin1", "UTF-8"). Use this setting when you get a UnicodeDecodeError error.
Each input CSV file must be a traditionally-delimited CSV (comma separated columns, newlines indicate new rows, double quoted values).

The first row is the header defining the attribute name for that column and will result to a column of the same name in the database. It must have a valid format with no spaces or special characters (like for example `!` or `@`, etc).
- name: csv_files_definition
label: CSV Files Definition
description: |
Project-relative path to JSON file holding array of objects with `entity`, `path`, and `keys` keys, as ascribed under [Files](#files):
Project-relative path to JSON file holding array of objects with `entity`, `path`, `keys`, and `encoding` [Optional] keys, as ascribed under [Files](#files):

```json
[
{
"entity": "<entity>",
"path": "<path>",
"keys": ["<key>"]
"keys": ["<key>"],
},
// ...
]
Expand Down