refactor: Started enforcing usage of structlog.stdlib.get_logger over logging.getLogger and banned use of the root logger
#8470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meltano canceled.
|
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/enforce-structlog-logging
branch
5 times, most recently
from
d46e678
to
be29f21
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8470 +/- ##
==========================================
+ Coverage 91.72% 91.78% +0.06%
==========================================
Files 245 245
Lines 19323 19325 +2
Branches 2150 2149 -1
==========================================
+ Hits 17724 17738 +14
+ Misses 1324 1313 -11
+ Partials 275 274 -1 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/enforce-structlog-logging
branch
7 times, most recently
from
eb63317
to
b1ec40b
Compare
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/enforce-structlog-logging
branch
3 times, most recently
from
b3a3e56
to
6ebf029
Compare
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/enforce-structlog-logging
branch
from
6ebf029
to
c373e33
Compare
…er `logging.getLogger`
edgarrmondragon
force-pushed
the
edgarrmondragon/refactor/enforce-structlog-logging
branch
from
c373e33
to
c972ad2
Compare
edgarrmondragon
changed the title
structlog.stdlib.get_logger over logging.getLoggerstructlog.stdlib.get_logger over logging.getLogger and banned use of the root logger
edgarrmondragon
commented
May 3, 2024
WillDaSilva
approved these changes
May 6, 2024
edgarrmondragon
deleted the
edgarrmondragon/refactor/enforce-structlog-logging
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
* Allow `install_plugins` call to optionally skip plugins that are already installed * Make plugin install methods async * Reuse existing skipped plugin install paradigm * Implement for `invoke` * Implement for `run` * Remove all files in a plugin run dir, not including the dir itself * POC: Disable install results output for `invoke` * Fix `invoke` failing tests * Address coverage warnings * Implement for `el`/`elt` * Default to showing plugin install status and results * Implement for `test` * Implement for `config <plugin> test` * POC: Display installation state/progress as logs if a logger is provided - otherwise fallback to `click` * Convert some CLI module logging to `structlog` to resolve mypy errors Related to #8470 * Add `--[no-]install` option to all affected commands and reuse for `add` * Update `install_plugins` patch * Implement for `select --list` * Use singular reason for just-in-time installs * Use plugin fingerprint to determine if install is required * Apply fixture to reset project context * Prevent test failure when `VenvService` is instantiated more that once * Safer to remove from explicit project root, rather than current working directory * Ignore missing test coverage Co-authored-by: Edgar Ramírez Mondragón <16805946+edgarrmondragon@users.noreply.github.com> * Fix typing issues * Apply suggestions from code review Co-authored-by: Edgar Ramírez Mondragón <16805946+edgarrmondragon@users.noreply.github.com> * Move plugin fingerprint read/write methods to `VirtualEnv` * Fix `WPS214` error * Add docs on `--[no-]install` usage for relevant commands * Address missing coverage * Do not require install if env vars are missing when expanding pip URL * Warn user when auto-install will not be performed due to missing env var for plugin `pip_url` * Update `skip_installed` kwarg to more fitting `auto_install` * Allow configuration of auto-install behaviour globally via env/`meltano.yml` * Change `JIT` install reason to `AUTO` * Use `AUTO` reason to indicate an auto-install, rather than explicit `auto_install` kwarg * Prevent `'NoneType' object has no attribute 'settings'` error when running commands outside of a project * Downgrade some install status/results logs to `DEBUG` when auto-installing * Don't show "Installing" message for a plugin that will be skipped immediately after * Update manifests * Add schema entry for `auto_install` --------- Co-authored-by: Edgar Ramírez Mondragón <16805946+edgarrmondragon@users.noreply.github.com> Co-authored-by: Edgar Ramírez-Mondragón <edgar@meltano.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some consistency to our logs when not using one of the built-in
meltano.core.loggingformatters:eventkey instead ofmessageenvironment=context varTODO:
logging.debugand similar calls?Note
This doesn't address 3rd party library logs