Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support stream property selection push-down in SQL streams #1032

Merged
merged 9 commits into from
Oct 5, 2022
Merged

feat: Support stream property selection push-down in SQL streams #1032

merged 9 commits into from
Oct 5, 2022

Conversation

kgpayne
Copy link
Contributor

@kgpayne kgpayne commented Oct 4, 2022 •
edited by github-actions bot
Loading

@kgpayne kgpayne mentioned this pull request Oct 4, 2022
Closed
@codecov
Copy link

codecov bot commented Oct 4, 2022 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.11%. Comparing base (6d74490) to head (43f656d).
Report is 1098 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
+ Coverage   83.00%   83.11%   +0.11%     
==========================================
  Files          39       39              
  Lines        3748     3743       -5     
  Branches      629      627       -2     
==========================================
  Hits         3111     3111              
+ Misses        473      470       -3     
+ Partials      164      162       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kgpayne kgpayne self-assigned this Oct 4, 2022
@kgpayne
Copy link
Contributor Author

kgpayne commented Oct 4, 2022

I think the pre-commit action is broken 🤔 The line it refers to has no typing.List import and flake8 doesn't find any lint errors locally 🤷‍♂️

edgarrmondragon
edgarrmondragon approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice refactoring too 😃

Note to myself: we need more intuitive end-to-end tests that check different inputs to SQL taps like catalog, state, etc.

singer_sdk/streams/sql.py Show resolved Hide resolved
@kgpayne kgpayne changed the title feat: support stream property selection in SQL streams feat: Support stream property selection push-down in SQL streams Oct 5, 2022
@kgpayne kgpayne merged commit e4db0d5 into main Oct 5, 2022
@kgpayne kgpayne deleted the kgpayne/issue974 branch October 5, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronsteers aaronsteers aaronsteers left review comments

@edgarrmondragon edgarrmondragon edgarrmondragon approved these changes

@cjohnhanson cjohnhanson Awaiting requested review from cjohnhanson

Assignees

@kgpayne kgpayne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: support stream property selection in SQL streams
3 participants
@kgpayne @edgarrmondragon @aaronsteers