chore: Enable INP Ruff checks
#1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<h2>Rationale</h2>
<p>Implicit namespace packages are directories of Python files without an <code>__init__.py</code>.
They’re valid and importable, but they break <em>many</em> tools, such as:</p>
<ul>
<li><p><a href="https://bugs.python.org/issue23882" rel="nofollow">unittest test discovery</a> (and by extension, Django’s test runner)</p></li>
<li><p><a href="nedbat/coveragepy#1024" rel="nofollow">Coverage.py</a></p></li>
<li><p>Mypy without its <a href="https://mypy.readthedocs.io/en/latest/command_line.html#import-discovery" rel="nofollow">–namespace-packages option</a></p></li>
<li><p><a href="pytest-dev/pytest#5147" rel="nofollow">pytest</a></p></li>
</ul>
https://pypi.org/project/flake8-no-pep420/
edgarrmondragon
requested review from
a team,
cjohnhanson and
aaronsteers
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1501 +/- ##
=======================================
Coverage 85.50% 85.50%
=======================================
Files 57 57
Lines 4760 4760
Branches 813 813
=======================================
Hits 4070 4070
Misses 498 498
Partials 192 192 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
WillDaSilva
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pypi.org/project/flake8-no-pep420/
📚 Documentation preview 📚: https://meltano-sdk--1501.org.readthedocs.build/en/1501/