fix: Add tests for SQL type conversion from JSON schemas #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #1775 +/- ##
==========================================
+ Coverage 85.61% 85.69% +0.08%
==========================================
Files 59 59
Lines 4937 4937
Branches 809 809
==========================================
+ Hits 4227 4231 +4
+ Misses 507 505 -2
+ Partials 203 201 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
for more information, see https://pre-commit.ci
edgarrmondragon
requested changes
Jun 19, 2023
…into fix_anyof_sql_types
edgarrmondragon
approved these changes
Jun 19, 2023
edgarrmondragon
changed the title
|
This is great, thanks @pnadolny13! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1774
I added tests that I let run in CI and they fail https://github.com/meltano/sdk/actions/runs/5315601259/jobs/9624162264 then I pushed the change that fixes them.
📚 Documentation preview 📚: https://meltano-sdk--1775.org.readthedocs.build/en/1775/