-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(targets): Parse dates with datetime.fromisoformat
/backports.datetime_fromisoformat
#2070
refactor(targets): Parse dates with datetime.fromisoformat
/backports.datetime_fromisoformat
#2070
Conversation
CodSpeed Performance ReportMerging #2070 will improve performances by ×45Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the mypy failure can be fixed by adding backports-datetime-fromisoformat
here:
https://github.com/buzzcutnorman/sdk/blob/a4bdd6674f5f59fda60fbad9dd01af046676dd6d/noxfile.py#L70
backports.datetime_fromisoformat
backports.datetime_fromisoformat
I should have noticed this initially but |
…etime-fromisoformat
…soformat' of https://github.com/BuzzCutNorman/sdk into 2046-refactor-parse-dates-with-backports-datetime-fromisoformat
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2070 +/- ##
==========================================
+ Coverage 87.48% 87.50% +0.01%
==========================================
Files 58 58
Lines 4875 4882 +7
Branches 993 996 +3
==========================================
+ Hits 4265 4272 +7
Misses 429 429
Partials 181 181 ☔ View full report in Codecov by Sentry. |
backports.datetime_fromisoformat
datetime.fromisoformat
/backports.datetime_fromisoformat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a bunch @BuzzCutNorman!
Replaced
python-dateutil.parse
withbackports.datetime_fromisoformat
.Changed except to ValueError.
Closes #2046
📚 Documentation preview 📚: https://meltano-sdk--2070.org.readthedocs.build/en/2070/