feat(target): Turn drain_one into a async method #2289
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes adding the asyncio module to the target base. Change
drain_one
into an async method and call it viaasyncio.run
. The thought isdrain_one
spends alot of time on io tasks and the use of asyncio will free up some of that time.I don't know how to resolve the pytest errors of:
Any guidance or assistance on how best to resolve these error is much appreciated.
📚 Documentation preview 📚: https://meltano-sdk--2289.org.readthedocs.build/en/2289/