Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Nested schema properties can now be defined as nullable #2488

Merged
merged 7 commits into from
Oct 18, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jun 18, 2024

Closes #2487


📚 Documentation preview 📚: https://meltano-sdk--2488.org.readthedocs.build/en/2488/

@edgarrmondragon edgarrmondragon changed the title feat: Let nested properties be nullable feat: Nested schema properties can now be defined as nullable Jun 18, 2024
Copy link

codspeed-hq bot commented Jun 18, 2024

CodSpeed Performance Report

Merging #2488 will not alter performance

Comparing edgarrmondragon/feat/nested-nullable-props (37c43f9) with main (4454aee)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.70%. Comparing base (4454aee) to head (37c43f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2488   +/-   ##
=======================================
  Coverage   90.70%   90.70%           
=======================================
  Files          62       62           
  Lines        5015     5016    +1     
  Branches      641      641           
=======================================
+ Hits         4549     4550    +1     
  Misses        325      325           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/nested-nullable-props branch from 4b40976 to 8b05077 Compare July 16, 2024 18:19
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/nested-nullable-props branch from 8b05077 to 4df8e21 Compare August 9, 2024 21:31
@edgarrmondragon edgarrmondragon added this to the 0.41.0 milestone Aug 14, 2024
@edgarrmondragon edgarrmondragon modified the milestones: v0.41.0, v0.42.0 Sep 4, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review October 10, 2024 01:59
@edgarrmondragon edgarrmondragon self-assigned this Oct 10, 2024
@edgarrmondragon edgarrmondragon merged commit 316282e into main Oct 18, 2024
40 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/feat/nested-nullable-props branch October 18, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Let nested properties be nullable when using schema helpers
1 participant