Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: In SQL targets, users can now disable column type alterations with the allow_column_alter built-in setting #2504

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jun 25, 2024

@edgarrmondragon edgarrmondragon linked an issue Jun 25, 2024 that may be closed by this pull request
@edgarrmondragon edgarrmondragon force-pushed the 1781-feat-configurable-target-schema-change-settings-by-default branch from db5c270 to 70be244 Compare June 25, 2024 10:58
Copy link

codspeed-hq bot commented Jun 25, 2024

CodSpeed Performance Report

Merging #2504 will not alter performance

Comparing 1781-feat-configurable-target-schema-change-settings-by-default (9dd667b) with main (39e1619)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.55%. Comparing base (39e1619) to head (9dd667b).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2504      +/-   ##
==========================================
+ Coverage   89.50%   89.55%   +0.04%     
==========================================
  Files          58       58              
  Lines        4804     4825      +21     
  Branches      943      943              
==========================================
+ Hits         4300     4321      +21     
  Misses        351      351              
  Partials      153      153              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the 1781-feat-configurable-target-schema-change-settings-by-default branch 7 times, most recently from 83ef0c2 to 119f183 Compare June 25, 2024 11:59
…ith the `allow_column_alter` built-in setting
@edgarrmondragon edgarrmondragon force-pushed the 1781-feat-configurable-target-schema-change-settings-by-default branch from 119f183 to 9dd667b Compare August 9, 2024 21:47
@edgarrmondragon edgarrmondragon added this to the 0.41.0 milestone Aug 14, 2024
@edgarrmondragon edgarrmondragon added the SQL Support for SQL taps and targets label Sep 4, 2024
@edgarrmondragon edgarrmondragon modified the milestones: v0.41.0, v0.42.0 Sep 4, 2024
@edgarrmondragon edgarrmondragon modified the milestones: v0.42.0, v0.43.0 Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SQL Support for SQL taps and targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: configurable target schema change settings by default
1 participant