Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to MeltanoLabs tap-snowflake #425

Closed
pnadolny13 opened this issue Sep 27, 2022 · 2 comments · Fixed by #494
Closed

Migrate to MeltanoLabs tap-snowflake #425

pnadolny13 opened this issue Sep 27, 2022 · 2 comments · Fixed by #494
Assignees

Comments

@pnadolny13
Copy link
Contributor

Once MeltanoLabs/tap-snowflake#2 merges we should test out that new tap and migrate once were comfortable.

@pnadolny13
Copy link
Contributor Author

pnadolny13 commented Dec 1, 2022

This PR is failing CI because of MeltanoLabs/tap-snowflake#10. It makes it hard to toggle schema/database across environments. Currently the isolation between CI runs that we had arent working so a job is accidentally retrieving data from other CI runs.

I could duplicate and override the selection criteria in the CI environment config (all other envs are working because schema are 1-1 with an env) but I'm still blocked with injecting my CI_BRANCH variable into the selection criteria because of meltano/meltano#3171.

My options:

  1. merge the new variant changes with the CI tests disabled
  2. keep the pipelinewise variant and CI tests enabled until Limit Discoverable Tables MeltanoLabs/tap-snowflake#10 is complete

@tayloramurphy @kgpayne What do you think? I'm planning to go with option 2 to be safe and keep everything working as is until theres a way to filter more.

@tayloramurphy
Copy link
Contributor

@pnadolny13 if it's not ready for primetime then let's wait until that issue is complete 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Planned
Development

Successfully merging a pull request may close this issue.

2 participants