Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented hopla hatch standard-egg {egg} {potion} #172

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

melvio
Copy link
Owner

@melvio melvio commented Oct 2, 2021

No description provided.

@melvio melvio linked an issue Oct 2, 2021 that may be closed by this pull request
@melvio melvio self-assigned this Oct 2, 2021
@melvio melvio force-pushed the enhancement/169-hopla-hatch branch from 4d6825d to 5379b18 Compare October 2, 2021 15:09
Copy link
Owner Author

@melvio melvio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self reviewed


@click.group()
def hatch():
"""hopla hatch group command."""
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use GROUP in documentation

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

# https://habitica.com/apidoc/#api-User-UserHatch

@pytest.mark.parametrize("pet_name,potion_name", [
("LionCub", "MossyStone"),
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also retrieve these from the Data classes. But fine for here


class TestHatchRequester:
@pytest.mark.parametrize("egg_name,potion_name", [
("Cheetah", "Base"),
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can also retrieve these from Data classes. But fine for now

@melvio melvio merged commit ab50edf into main Oct 2, 2021
@melvio melvio deleted the enhancement/169-hopla-hatch branch October 2, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hopla hatch command - normal pets
1 participant