Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/184 hatch all with lots of pets with few potions #185

Merged
merged 2 commits into from
Oct 3, 2021
Merged

bugfix/184 hatch all with lots of pets with few potions #185

merged 2 commits into from
Oct 3, 2021

Conversation

melvio
Copy link
Owner

@melvio melvio commented Oct 3, 2021

  • WIP: Fixed the bug, cleanup required
  • Cleanup and add test that cover the bugfix

@melvio melvio self-assigned this Oct 3, 2021
@melvio melvio added hopla-hatch-all hopla hatch-all command bug Something isn't working labels Oct 3, 2021
@melvio melvio linked an issue Oct 3, 2021 that may be closed by this pull request
hatch-all with lots of pets but few potions might fail to hatch all pets #184
Closed
melvio
melvio commented Oct 3, 2021
View reviewed changes
Copy link
Owner Author

@melvio melvio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-reviewed

@melvio melvio merged commit e0f8b69 into main Oct 3, 2021
@melvio melvio deleted the bugfix/184-hatch-all-with-lots-of-pets-with-few-potions branch October 3, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@melvio melvio

Labels
bug Something isn't working hopla-hatch-all hopla hatch-all command
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hatch-all with lots of pets but few potions might fail to hatch all pets
1 participant
@melvio