Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement/160 until out of mana option #199

Merged
merged 5 commits into from
Oct 10, 2021
Merged

enhancement/160 until out of mana option #199

merged 5 commits into from
Oct 10, 2021

Conversation

melvio
Copy link
Owner

@melvio melvio commented Oct 10, 2021

  • Fix comment error
  • Add mana information to spell models
  • Shorten spell.spell_name to spell.name
  • Add --until-out-of-mana
  • Add -u and add unittest

@melvio melvio force-pushed the enhancement/160-until-out-of-mana-option branch from 9d94952 to ddd82c2 Compare October 10, 2021 16:41
@melvio melvio force-pushed the enhancement/160-until-out-of-mana-option branch 2 times, most recently from 775a0ad to 18af052 Compare October 10, 2021 16:44
@melvio melvio force-pushed the enhancement/160-until-out-of-mana-option branch from 18af052 to 96e043d Compare October 10, 2021 16:44
@melvio melvio force-pushed the enhancement/160-until-out-of-mana-option branch from e0a1831 to b04c519 Compare October 10, 2021 16:55
@melvio melvio marked this pull request as ready for review October 10, 2021 16:55
melvio
melvio commented Oct 10, 2021
View reviewed changes
Copy link
Owner Author

@melvio melvio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self reviewed

src/tests/hoplalib/cast/test_spellmodel.py Outdated
spell = Spell(name=spell_name)
assert spell.name == spell_name
assert 15 <= spell.mana_required <= 45
assert spell.class_name in ["wizard", "healer", "rogue", "warrior"]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a HabiticaClassData for this list

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@melvio melvio linked an issue Oct 10, 2021 that may be closed by this pull request
Implement --until-no-mana-left for hopla cast #160
Closed
@melvio melvio added the hopla-cast hopla cast command label Oct 10, 2021
@melvio melvio self-assigned this Oct 10, 2021
@melvio melvio merged commit b1d319c into main Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@melvio melvio

Labels
hopla-cast hopla cast command
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement --until-no-mana-left for hopla cast
1 participant
@melvio