Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: pass anything as metadata #317

Closed
cachho opened this issue Jul 18, 2023 · 2 comments
Closed

feature request: pass anything as metadata #317

cachho opened this issue Jul 18, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@cachho
Copy link
Contributor

cachho commented Jul 18, 2023

🚀 The feature

You should be able to pass anything as metadata, through the input of a dict.

This applies to the add method mostly. This should be added to AddConfig.

But then you should also be able to filter the query with where from the QueryConfig.

Motivation, pitch

Let's say you want to evaluate URLs, but one site is JS based so you use selenium to get the text and then load add it with the text datatype. Now it does not have the source metadata tag.

Alternatives

No response

Additional context

No response

@cachho cachho added the enhancement New feature or request label Jul 18, 2023
@aaishikdutta
Copy link
Contributor

aaishikdutta commented Jul 19, 2023

hi @cachho, can you please provide detail? Also, I thought we had metadata parameter in add method that can take in a dict and it was added to the metadata generated by loaders. I guess it was this PR #253

@cachho
Copy link
Contributor Author

cachho commented Jul 20, 2023

hi @cachho, can you please provide detail? Also, I thought we had metadata parameter in add method that can take in a dict and it was added to the metadata generated by loaders. I guess it was this PR #253

you're right, looks like we already have this.

@cachho cachho closed this as completed Jul 20, 2023
@cachho cachho mentioned this issue Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants