Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-feature request - Modularize the application #95

Closed
aaishikdutta opened this issue Jun 28, 2023 · 3 comments
Closed

Non-feature request - Modularize the application #95

aaishikdutta opened this issue Jun 28, 2023 · 3 comments

Comments

@aaishikdutta
Copy link
Contributor

The Embedchain class has a lot of methods and it would add value in terms of code readability to abstract it a little bit. There are many open issues about integrating multiple llms, vector dbs or embedding. While I see a level of abstraction in the vector db folder and that can be leveraged for further integration options, I believe we should do something similar for the methods where we use the embedding models and the llm model. I have raised a PR for this #92 which attends to abstracting the data formats for loaders and chunkers . @taranjeet @cachho please let me know if this is something we can add, so we can have some further discussions on how to structure it for the more critical pieces like the embedding models and chat completions.

@taranjeet
Copy link
Member

Hey @aaishikdutta , I am getting back to this issue in some time.

@cachho
Copy link
Contributor

cachho commented Jun 28, 2023

Since you tagged me, I think we have should merge #70 first, and then get back to this idea. Thanks for the PR.

@taranjeet
Copy link
Member

We are already revamping the framework, so closing this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants