Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] fix typo in opensearch db #1218

Merged
merged 1 commit into from
Jan 26, 2024
Merged

[Bugfix] fix typo in opensearch db #1218

merged 1 commit into from
Jan 26, 2024

Conversation

deven298
Copy link
Contributor

@deven298 deven298 commented Jan 26, 2024

Description

This PR fixes opensearch db bug.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (344dbee) 56.30% compared to head (397da04) 56.60%.
Report is 3 commits behind head on main.

Files Patch % Lines
embedchain/vectordb/opensearch.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
+ Coverage   56.30%   56.60%   +0.30%     
==========================================
  Files         146      146              
  Lines        5902     5920      +18     
==========================================
+ Hits         3323     3351      +28     
+ Misses       2579     2569      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deven298 deven298 merged commit 433f99d into main Jan 26, 2024
4 of 5 checks passed
@deven298 deven298 deleted the fix/opensearch_db branch January 26, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenSearch throws KeyError: bool
1 participant