Update URL Validation Regex to Support IP Addresses and Port Numbers #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
taranjeet
reviewed
Jan 31, 2024
juananpe
force-pushed
the
validjsonurl
branch
from
76a1793
to
c8c0534
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1233 +/- ##
=======================================
Coverage 56.60% 56.60%
=======================================
Files 146 146
Lines 5923 5923
=======================================
Hits 3353 3353
Misses 2570 2570 ☔ View full report in Codecov by Sentry. |
|
This looks good. Merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the URL validation regex to accommodate URLs with http or https protocols, IP addresses, optional port numbers, and URL-encoded characters, ensuring broader validation coverage. This change allows the system to correctly validate URLs like http://192.168.1.140:9000/1%202%20Inflación-wav.json, which include direct IP access with port specifications and encoded characters, enhancing compatibility with a wider range of URLs.
Fixes #1232
Type of change