Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Fix test #1255

Merged
merged 1 commit into from
Feb 12, 2024
Merged

[Bug fix] Fix test #1255

merged 1 commit into from
Feb 12, 2024

Conversation

deshraj
Copy link
Collaborator

@deshraj deshraj commented Feb 12, 2024

Description

Missed to fix the test in my last PR.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d94aee8) 56.52% compared to head (44f0bd8) 56.54%.
Report is 2 commits behind head on main.

Files Patch % Lines
embedchain/llm/openai.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
+ Coverage   56.52%   56.54%   +0.01%     
==========================================
  Files         146      146              
  Lines        5935     5937       +2     
==========================================
+ Hits         3355     3357       +2     
  Misses       2580     2580              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deshraj deshraj merged commit 38e212c into main Feb 12, 2024
5 checks passed
@deshraj deshraj deleted the user/dyadav/fix-tests branch February 12, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant