Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Fix vertex ai integration issue #1257

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

deshraj
Copy link
Collaborator

@deshraj deshraj commented Feb 14, 2024

Description

Reported by a user on our slack here: https://embedchain.slack.com/archives/C05RG7CJKC6/p1707888213859569

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Unit Test

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (41bd258) 56.68% compared to head (8a14edb) 56.56%.
Report is 1 commits behind head on main.

Files Patch % Lines
embedchain/llm/vertex_ai.py 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1257      +/-   ##
==========================================
- Coverage   56.68%   56.56%   -0.13%     
==========================================
  Files         146      146              
  Lines        5943     5944       +1     
==========================================
- Hits         3369     3362       -7     
- Misses       2574     2582       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deshraj deshraj merged commit 0766a44 into main Feb 14, 2024
3 of 5 checks passed
@deshraj deshraj deleted the user/dyadav/vertex-ai-resolve branch February 14, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant