Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for supplying custom db params #1276

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

deshraj
Copy link
Collaborator

@deshraj deshraj commented Feb 21, 2024

Description

Changes:

  • Add support for passing any db connection params
  • Refactor some of the code

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit Test

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 21, 2024
@deshraj deshraj force-pushed the user/dyadav/add-embedchain-memory branch from dc9b5e3 to 5ba1360 Compare February 21, 2024 21:31
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8f69ea) 56.78% compared to head (698c34e) 56.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1276      +/-   ##
==========================================
- Coverage   56.78%   56.74%   -0.05%     
==========================================
  Files         150      150              
  Lines        6068     6064       -4     
==========================================
- Hits         3446     3441       -5     
- Misses       2622     2623       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deshraj deshraj merged commit aa5ad62 into main Feb 22, 2024
4 of 5 checks passed
@deshraj deshraj deleted the user/dyadav/add-embedchain-memory branch August 24, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant