Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/Improvements] Delete data sources from metadata db when using app.delete() #1286

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

deshraj
Copy link
Collaborator

@deshraj deshraj commented Feb 26, 2024

Description

Changes:

  • Delete row from data sources whenever someone calls app.delete()
  • Delete the chat history when someone calls app.reset()
  • Add support for passing custome bm25encoder when using pinecone vector database

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit Test

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 56.44%. Comparing base (92dd7ed) to head (10ed893).

Files Patch % Lines
embedchain/embedchain.py 33.33% 8 Missing ⚠️
embedchain/vectordb/pinecone.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1286      +/-   ##
==========================================
- Coverage   56.49%   56.44%   -0.06%     
==========================================
  Files         151      151              
  Lines        6101     6110       +9     
==========================================
+ Hits         3447     3449       +2     
- Misses       2654     2661       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deshraj deshraj merged commit 752f638 into main Feb 26, 2024
3 of 5 checks passed
@deshraj deshraj deleted the user/dyadav/improvements branch August 24, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant