Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Fix deprecation warnings #1288

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

deshraj
Copy link
Collaborator

@deshraj deshraj commented Feb 27, 2024

Description

Seeing some warnings from langchain about call getting deprecated from version 0.2.0. Fixed that warning in this PR.

Type of change

  • Refactor (does not change functionality, e.g. code style improvements, linting)

How Has This Been Tested?

  • Unit Test

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 27, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 56.44%. Comparing base (752f638) to head (4ca45a7).
Report is 1 commits behind head on main.

Files Patch % Lines
embedchain/llm/vllm.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1288   +/-   ##
=======================================
  Coverage   56.44%   56.44%           
=======================================
  Files         151      151           
  Lines        6110     6110           
=======================================
  Hits         3449     3449           
  Misses       2661     2661           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deshraj deshraj merged commit 09cdaff into main Feb 27, 2024
5 checks passed
@deshraj deshraj deleted the user/dyadav/fix-warnings branch February 27, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant