Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Fix issue related to get_data_sources() method #1295

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

deshraj
Copy link
Collaborator

@deshraj deshraj commented Mar 1, 2024

Description

Noticed the issue where get_data_sources() function is failing due to the recent change in the schema.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.85%. Comparing base (c77a75d) to head (50df825).

Files Patch % Lines
embedchain/app.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1295   +/-   ##
=======================================
  Coverage   55.85%   55.85%           
=======================================
  Files         153      153           
  Lines        6169     6169           
=======================================
  Hits         3446     3446           
  Misses       2723     2723           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deshraj deshraj merged commit 91044ec into main Mar 1, 2024
5 checks passed
@deshraj deshraj deleted the user/dyadav/fix-data-sources-func branch March 1, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant