Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Excel files #1319

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Conversation

Dev-Khant
Copy link
Collaborator

Description

Added support for excel files.

Fixes #1103

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation update

How Has This Been Tested?

  • Unit Test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 63.88889% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 55.85%. Comparing base (c181ccb) to head (f90c44a).
Report is 2 commits behind head on main.

❗ Current head f90c44a differs from pull request most recent head ca6254a. Consider uploading reports for the commit ca6254a to get more accurate results

Files Patch % Lines
embedchain/loaders/excel_file.py 40.90% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1319      +/-   ##
==========================================
+ Coverage   55.80%   55.85%   +0.04%     
==========================================
  Files         154      156       +2     
  Lines        6232     6268      +36     
==========================================
+ Hits         3478     3501      +23     
- Misses       2754     2767      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dev-Khant
Copy link
Collaborator Author

@deshraj Can you please review this?

pyproject.toml Outdated
@@ -123,6 +123,8 @@ cohere = { version = "^4.27", optional = true }
together = { version = "^0.2.8", optional = true }
weaviate-client = { version = "^3.24.1", optional = true }
docx2txt = { version = "^0.8", optional = true }
openpyxl = { version = "^3.1.2", optional = true }
xlrd = { version = "^2.0.1", optional = true }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going forward, we are planning to not add everything to the optional dependencies. Instead, can you please:

  1. Add instructions in the docs to install these two packages
  2. Try to import these on the loader file and if import fails, show the exception to install these packages.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deshraj I have made the change, please check

@Dev-Khant
Copy link
Collaborator Author

@deshraj Tests are failing because of Qdrant vectordb

@Dev-Khant Dev-Khant requested a review from deshraj March 23, 2024 02:47
@Dev-Khant
Copy link
Collaborator Author

Hi @deshraj Can you please review it?

@Dev-Khant
Copy link
Collaborator Author

@deshraj @taranjeet Please can you review this?

@deshraj deshraj merged commit 6c32d28 into mem0ai:main Apr 16, 2024
0 of 3 checks passed
@Dev-Khant Dev-Khant deleted the support-for-excel-files branch June 7, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excel File Support
2 participants