-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Excel files #1319
Support for Excel files #1319
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1319 +/- ##
==========================================
+ Coverage 55.80% 55.85% +0.04%
==========================================
Files 154 156 +2
Lines 6232 6268 +36
==========================================
+ Hits 3478 3501 +23
- Misses 2754 2767 +13 ☔ View full report in Codecov by Sentry. |
@deshraj Can you please review this? |
pyproject.toml
Outdated
@@ -123,6 +123,8 @@ cohere = { version = "^4.27", optional = true } | |||
together = { version = "^0.2.8", optional = true } | |||
weaviate-client = { version = "^3.24.1", optional = true } | |||
docx2txt = { version = "^0.8", optional = true } | |||
openpyxl = { version = "^3.1.2", optional = true } | |||
xlrd = { version = "^2.0.1", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going forward, we are planning to not add everything to the optional dependencies. Instead, can you please:
- Add instructions in the docs to install these two packages
- Try to import these on the loader file and if import fails, show the exception to install these packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deshraj I have made the change, please check
@deshraj Tests are failing because of Qdrant vectordb |
Hi @deshraj Can you please review it? |
@deshraj @taranjeet Please can you review this? |
Description
Added support for excel files.
Fixes #1103
Type of change
How Has This Been Tested?
Checklist:
Maintainer Checklist