Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvements] Improve logging and fix insertion in data_sources table #1337

Merged
merged 1 commit into from
Apr 11, 2024
Merged

[Improvements] Improve logging and fix insertion in data_sources table #1337

merged 1 commit into from
Apr 11, 2024

Conversation

deshraj
Copy link
Collaborator

@deshraj deshraj commented Apr 11, 2024

Description

Changes:

  • Fix issue when the source type in data_sources is not a string. Convert it specifically
  • Convert the print statements to logging

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@deshraj deshraj merged commit 536f85b into main Apr 11, 2024
0 of 3 checks passed
@deshraj deshraj deleted the user/dyadav/package-logging-improvements branch April 11, 2024 22:00
@deshraj
Copy link
Collaborator Author

deshraj commented Apr 11, 2024

Qdrant related tests seems to be failing due to a different issue. We will fix it in a follow up PR.

@cpanissod cpanissod mentioned this pull request Apr 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deshraj