-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bedrock embedder #1470
Feature/bedrock embedder #1470
Conversation
dd1fecc
to
cc424b6
Compare
6ae5699
to
a60a56b
Compare
@andrewghlee Please can you remove the changes from file that is not related to AWS embedder as it's hard to review these many files. And please feel to open separate PRs for those changes. |
@Dev-Khant Done here! My apologies. |
3fe1a1d
to
cdebd47
Compare
@Dev-Khant Just a friendly nudge for this PR. I totally understand that you guys are busy with mem0 integration. |
@andrewghlee Hey sure, PR looks good to me. Let me fix the failing tests first and then we are good to merge this PR. |
cdebd47
to
774f5c7
Compare
@Dev-Khant I think one of the undone changes had the failing test resolved actually. I cherrypicked that specific file and ran |
@andrewghlee can you please resolve conflicts? |
22a1b0f
to
1c89b26
Compare
@deshraj Done! Rebased with latest main and made sure poetry lock is current. |
@andrewghlee Thanks for working on this PR! |
Description
This PR adds aws_bedrock embedder to embedchain and makes minor changes to the existing code such as the following:
langchain-aws
instead oflangchain-community
for aws_bedrock llmAWS_REGION
orAWS_DEFAULT_REGION
before defaulting tous-west-2
--force-excluded
as it is already done in pyproject.tomlmake lint
andmake format
as specified CONTRIBUTING.MDpip install
in Makefile)Fixes # (issue)
1471
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please delete options that are not relevant.
Checklist:
Maintainer Checklist