Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bedrock embedder #1470

Merged
merged 7 commits into from
Aug 1, 2024
Merged

Conversation

andrewghlee
Copy link
Contributor

@andrewghlee andrewghlee commented Jul 12, 2024

Description

This PR adds aws_bedrock embedder to embedchain and makes minor changes to the existing code such as the following:

  • Use langchain-aws instead of langchain-community for aws_bedrock llm
  • Use AWS_REGION or AWS_DEFAULT_REGION before defaulting to us-west-2
  • Update pre-commit config file to use newer version of ruff and remove --force-excluded as it is already done in pyproject.toml
  • Add isort to pre-commit config file and have pre-commit follow the same steps in make lint and make format as specified CONTRIBUTING.MD
  • Remove pinned versions for packages that share dependencies with langchain-aws such as opensearch-py (pyproject.toml) and boto3 (pip install in Makefile)

Fixes # (issue)
1471

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@andrewghlee andrewghlee force-pushed the feature/bedrock-embedder branch 2 times, most recently from dd1fecc to cc424b6 Compare July 18, 2024 18:23
@andrewghlee andrewghlee force-pushed the feature/bedrock-embedder branch 3 times, most recently from 6ae5699 to a60a56b Compare July 24, 2024 13:45
@Dev-Khant
Copy link
Collaborator

@andrewghlee Please can you remove the changes from file that is not related to AWS embedder as it's hard to review these many files.

And please feel to open separate PRs for those changes.

@andrewghlee
Copy link
Contributor Author

@andrewghlee Please can you remove the changes from file that is not related to AWS embedder as it's hard to review these many files.

And please feel to open separate PRs for those changes.

@Dev-Khant Done here!

My apologies. make format must have corrected other files.

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2024

CLA assistant check
All committers have signed the CLA.

@andrewghlee
Copy link
Contributor Author

@Dev-Khant Just a friendly nudge for this PR. I totally understand that you guys are busy with mem0 integration.

@Dev-Khant
Copy link
Collaborator

@andrewghlee Hey sure, PR looks good to me. Let me fix the failing tests first and then we are good to merge this PR.

@andrewghlee
Copy link
Contributor Author

andrewghlee commented Jul 30, 2024

@Dev-Khant I think one of the undone changes had the failing test resolved actually. I cherrypicked that specific file and ran make coverage and got 419 passed, 3 skipped, 21 warnings in 54.52s.

@deshraj
Copy link
Collaborator

deshraj commented Jul 31, 2024

@andrewghlee can you please resolve conflicts?

@andrewghlee
Copy link
Contributor Author

@deshraj Done! Rebased with latest main and made sure poetry lock is current.

@Dev-Khant
Copy link
Collaborator

@andrewghlee Thanks for working on this PR!

@Dev-Khant Dev-Khant merged commit 563a130 into mem0ai:main Aug 1, 2024
6 checks passed
shlokkhemani pushed a commit that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants