Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for aws_bedrock embedder #1472

Closed
wants to merge 1 commit into from

Conversation

hung-phan
Copy link

@hung-phan hung-phan commented Jul 12, 2024

Description

This PR is to add integration for AWS Bedrock embedder

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation update

How Has This Been Tested?

  • Unit Test
  • Test Script (please provide): Notebook for aws_bedrock

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@hung-phan hung-phan force-pushed the feat-aws-bedrock-embedder branch 3 times, most recently from 8d7d556 to 223e665 Compare July 12, 2024 08:57
@hung-phan hung-phan mentioned this pull request Jul 12, 2024
@hung-phan hung-phan force-pushed the feat-aws-bedrock-embedder branch 2 times, most recently from 5c31b11 to 8fa7048 Compare July 12, 2024 17:52
@Dev-Khant
Copy link
Collaborator

Hi @hung-phan, Can you please resolve the conflicts so that we can review and test the PR.

@hung-phan
Copy link
Author

hung-phan commented Jul 20, 2024

@Dev-Khant, will do it shortly today

@hung-phan
Copy link
Author

Updated @Dev-Khant

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2024

CLA assistant check
All committers have signed the CLA.

@Dev-Khant
Copy link
Collaborator

@hung-phan Can you please resolve the conflicts?

@hung-phan hung-phan closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants