Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mem0 fix in embedchain #1506

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Mem0 fix in embedchain #1506

merged 2 commits into from
Jul 19, 2024

Conversation

Dev-Khant
Copy link
Collaborator

Description

Fixes few issues related to mem0 integration in embedchain.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

deshraj
deshraj approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@deshraj deshraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Can you please bump up the version so that we can release a new version?

@deshraj
Copy link
Collaborator

deshraj commented Jul 19, 2024

@Dev-Khant can you please check why the CI tests are failing for Embedchain here?

@deshraj deshraj merged commit 51fd7db into main Jul 19, 2024
2 of 5 checks passed
@deshraj deshraj deleted the user/dev/embedchain-fixes branch July 19, 2024 22:03
Jacksonxhx pushed a commit to Jacksonxhx/mem0 that referenced this pull request Jul 31, 2024
@Dev-Khant @Jacksonxhx
Mem0 fix in embedchain (mem0ai#1506)
f05e04b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deshraj deshraj deshraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dev-Khant @deshraj