Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure OpenAI LLM #1581

Merged
merged 3 commits into from
Aug 3, 2024
Merged

Conversation

kmitul
Copy link
Contributor

@kmitul kmitul commented Jul 25, 2024

Description

This PR, built on top of PR #1574 , introduces a dedicated integration with Azure OpenAI LLM. It fixes issues encountered when using Azure OpenAI LLMs via LiteLLM configs and ensures seamless integration.

Fixes #1580

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@kmitul kmitul changed the title Feat/add azure openai Support Azure OpenAI LLM Jul 25, 2024
@kmitul kmitul marked this pull request as draft July 26, 2024 01:52
@mem0ai mem0ai deleted a comment from CLAassistant Jul 26, 2024
@CLAassistant
Copy link

CLAassistant commented Jul 26, 2024

CLA assistant check
All committers have signed the CLA.

@kmitul kmitul marked this pull request as ready for review July 28, 2024 07:02
@kmitul
Copy link
Contributor Author

kmitul commented Jul 30, 2024

Hi @deshraj @taranjeet @Dev-Khant
I wanted to kindly request a review for this PR when you have a moment.

@Dev-Khant
Copy link
Collaborator

Hey @kmitul, Will review this PR soon.

@kmitul kmitul force-pushed the feat/add-azure-openai branch 2 times, most recently from f9cfaac to 9d92c1e Compare August 3, 2024 01:52
Updated LLM Documentation for properly configuring Azure OpenAI models.
Copy link
Collaborator

@Dev-Khant Dev-Khant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmitul Can you please update this <Card title="OpenAI Azure" href="#openai-azure"></Card> according to new name which is Azure OpenAI in docs.

Fixed card title for Azure OpenAI
@kmitul
Copy link
Contributor Author

kmitul commented Aug 3, 2024

@Dev-Khant
Thanks for the review. Fixed the title in docs.

@Dev-Khant
Copy link
Collaborator

@kmitul Looks good, thanks for working on this.

@Dev-Khant Dev-Khant merged commit 81b4431 into mem0ai:main Aug 3, 2024
5 checks passed
shlokkhemani pushed a commit that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure OpenAI LLM not working
3 participants