Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'PersonApp.py' to 'person_app.py' #752

Merged
merged 5 commits into from
Oct 9, 2023

Conversation

Prikshit7766
Copy link
Contributor

@Prikshit7766 Prikshit7766 commented Oct 1, 2023

Description

This PR renames 'PersonApp.py' to 'person_app.py' to follow snake case convention and updates related imports accordingly.

Fixes #667

  • Refactor (does not change functionality, e.g. code style improvements, linting)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
embedchain/__init__.py 100.00% <100.00%> (ø)
embedchain/apps/person_app.py 51.35% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@Prikshit7766
Copy link
Contributor Author

@deshraj
Thanks for approving the PR. If everything's okay, can you please merge it?

@deshraj deshraj merged commit ed02aeb into mem0ai:main Oct 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename apps/PersonApp.py to follow snake case convention
2 participants