Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix issue when llm config is not defined #763

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

deshraj
Copy link
Collaborator

@deshraj deshraj commented Oct 4, 2023

Description

Recent integration of the CLIP model is breaking the package with AttributeError since the llm config is optional to pass in the CustomApp. This PR adds a check for the same to fix the issue.

Also, ran make format to prettify the code.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
embedchain/config/llm/base_llm_config.py 94.73% <ø> (ø)
embedchain/data_formatter/data_formatter.py 86.79% <100.00%> (ø)
embedchain/embedchain.py 73.89% <100.00%> (ø)
embedchain/llm/gpt4all.py 66.66% <ø> (ø)
embedchain/models/clip_processor.py 84.21% <100.00%> (ø)
embedchain/vectordb/chroma.py 82.79% <100.00%> (ø)
embedchain/vectordb/elasticsearch.py 67.53% <100.00%> (ø)
embedchain/loaders/images.py 30.00% <66.66%> (ø)

📢 Thoughts on this report? Let us know!.

@deshraj deshraj merged commit 87d0b5c into main Oct 4, 2023
5 checks passed
@deshraj deshraj deleted the user/dyadav/fix-package-issues branch October 4, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant