Improve and add more tests #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidmohanty11
force-pushed
the
feature/improve-tests-v4
branch
from
3cfe768
to
5797454
Compare
Codecov ReportAll modified lines are covered by tests ✅
... and 9 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
deshraj
reviewed
Oct 16, 2023
pyproject.toml
Outdated
| @@ -120,6 +120,7 @@ ftfy = { version = "6.1.1", optional = true } | |||
| regex = { version = "2023.8.8", optional = true } | |||
| huggingface_hub = { version = "^0.17.3", optional = true } | |||
| pymilvus = "2.3.1" | |||
| pytest-asyncio = "^0.21.1" | |||
There was a problem hiding this comment.
It should be part of the dev dependencies.
There was a problem hiding this comment.
Also, I am not sure if we really need this package btw.
There was a problem hiding this comment.
@deshraj thank you, I've added it to dev dependency. It's actually needed by a test for the Poe bot, which uses async code that's not currently running and is being skipped.
deshraj
reviewed
Oct 16, 2023
tests/llm/test_huggingface.py
Outdated
| assert answer == "Test answer" | ||
| mock_llm_instance.assert_called_once_with("Test query") | ||
| mock_llm_instance.assert_called_once_with("Test query") | ||
| mock_llm_instance.assert_called_once_with("Test query") |
There was a problem hiding this comment.
Do we need to call this three times? I am a bit confused here 😅
There was a problem hiding this comment.
Sorry for the miss, yup you're right! I've removed it :)
sidmohanty11
force-pushed
the
feature/improve-tests-v4
branch
from
571f2eb
to
b793d21
Compare
deshraj
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Open AI LLM for streaming and adds more tests