Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local file path support to SitemapLoader #954

Merged
merged 3 commits into from
Dec 23, 2023

Conversation

Prikshit7766
Copy link
Contributor

Description

This pull request adds local file path support to the SitemapLoader class, enabling the loader to fetch data from local file paths.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (9fe80c5) 58.31% compared to head (6682620) 58.26%.

Files Patch % Lines
embedchain/loaders/sitemap.py 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #954      +/-   ##
==========================================
- Coverage   58.31%   58.26%   -0.06%     
==========================================
  Files         128      128              
  Lines        4988     4993       +5     
==========================================
  Hits         2909     2909              
- Misses       2079     2084       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Prikshit7766, thanks a lot! LGTM, just added a minor comment

embedchain/loaders/sitemap.py Outdated Show resolved Hide resolved
@Prikshit7766
Copy link
Contributor Author

Thanks for the review! I've made the changes. Let me know what you think.

Copy link
Contributor

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Prikshit7766 !

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 22, 2023
@sidmohanty11 sidmohanty11 merged commit 106a338 into mem0ai:main Dec 23, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sitemap loader doesn't work with local files
2 participants