Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sitemap loader #986

Merged
merged 4 commits into from
Dec 6, 2023
Merged

fix sitemap loader #986

merged 4 commits into from
Dec 6, 2023

Conversation

deven298
Copy link
Contributor

@deven298 deven298 commented Dec 4, 2023

Description

Avoid using is_readable as there could be emojis on the page which are considered unreadable. Emojis could be in markdown file or webpage.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (36af1a7) 64.34% compared to head (f60e1ee) 64.38%.
Report is 1 commits behind head on main.

Files Patch % Lines
embedchain/loaders/sitemap.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
+ Coverage   64.34%   64.38%   +0.04%     
==========================================
  Files         118      118              
  Lines        4406     4403       -3     
==========================================
  Hits         2835     2835              
+ Misses       1571     1568       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deshraj deshraj merged commit c9fbc2e into main Dec 6, 2023
4 of 5 checks passed
@deshraj deshraj deleted the fix/sitemap branch December 6, 2023 01:56
deshraj pushed a commit that referenced this pull request Dec 14, 2023
Co-authored-by: Deven Patel <deven298@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants