Implemented delete corpus using celery. Also made many refactors #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxyu1115
force-pushed
the
delete-corpus
branch
from
b5d18f7
to
3c33e9e
Compare
AlexArtrip
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented delete corpus using celery, a task queue worker using redis.
The delete_corpus api first sends a task to celery, and then initiates the delete, by deleting the NamespaceNameToId entry. From the user perspective, while all the actual data remains, this effectively deletes the corpus, since the user no longer has any means to access the corpus. The celery worker then picks up the deletion, making sure the NamespaceNameToId is deleted, and then deletes all the data within the corpus.
Also made many minor refactors, such as to the get query corpus function.