Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run user creation in DB transaction #207

Closed
mrhead opened this issue Aug 9, 2017 · 2 comments
Closed

Run user creation in DB transaction #207

mrhead opened this issue Aug 9, 2017 · 2 comments

Comments

@mrhead
Copy link
Contributor

mrhead commented Aug 9, 2017

I am not sure if this is possible, but it could help us avoid issues like we had in #206. Where a WordPress user has been created, but then the request failed before we created an entry in wp_memberful_mapping so we couldn't map WordPress users to Memberful members.
@dstrojny
Copy link
Contributor

dstrojny commented Aug 9, 2017

Isn't this the same idea in #153? From that issue:

Ideally, we'd wrap the whole WordPress user creation and Memberful mapping process in a transaction, but as WordPress doesn't require InnoDB, we can't rely on it being present.

@mrhead
Copy link
Contributor Author

mrhead commented Aug 10, 2017

Yes, it is the same idea! I'm closing this issue in favour of #153. But we should definitely address it.

@mrhead mrhead closed this as completed Aug 10, 2017
@mrhead mrhead mentioned this issue Aug 10, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dstrojny @mrhead