Add support for remote mdns candidates #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
force-pushed
the
mdns-candidates
branch
6 times, most recently
from
539b2fd
to
e328194
Compare
|
depends on rosetta-home/mdns#19 |
mickel8
force-pushed
the
mdns-candidates
branch
4 times, most recently
from
33d6e03
to
778224c
Compare
mat-hek
reviewed
May 18, 2021
lib/ex_libnice.ex
Outdated
Comment on lines
420
to
423
| state = %{ | ||
| state | ||
| | mdns_queries: Map.put(state.mdns_queries, address, {candidate, stream_id, component_id}) | ||
| } |
lib/ex_libnice.ex
Outdated
Comment on lines
544
to
546
|
|
||
| state = | ||
| case Map.pop(state.mdns_queries, dev.domain) do |
There was a problem hiding this comment.
Suggested change
| state = | |
| case Map.pop(state.mdns_queries, dev.domain) do | |
| {query, state} = pop_in(state, [:mdns_queries, dev.domain]) | |
| case query do |
mat-hek
reviewed
May 19, 2021
lib/ex_libnice.ex
Outdated
| | mdns_queries: Map.put(state.mdns_queries, address, {candidate, stream_id, component_id}) | ||
| } | ||
|
|
||
| state = Struct.put_in(state, [:mdns_queries, address], {candidate, stream_id, component_id}) |
There was a problem hiding this comment.
better use Bunch.Access in the state
lib/ex_libnice.ex
Outdated
Comment on lines
418
to
420
| withl address_error: address when address != nil <- Enum.at(candidate_sp, 4), | ||
| parse_error: 6 <- length(candidate_sp), | ||
| not_mdns: true <- String.ends_with?(address, ".local") do |
There was a problem hiding this comment.
Suggested change
| withl address_error: address when address != nil <- Enum.at(candidate_sp, 4), | |
| parse_error: 6 <- length(candidate_sp), | |
| not_mdns: true <- String.ends_with?(address, ".local") do | |
| withl candidate_check: 6 <- length(candidate_sp), | |
| do: address = Enum.at(candidate_sp, 4), | |
| mdns_check: true <- String.ends_with?(address, ".local") do |
lib/ex_libnice.ex
Outdated
Comment on lines
426
to
428
| address_error: _ -> {:reply, {:error, :failed_to_parse_sdp_string}, state} | ||
| parse_error: _ -> {:reply, {:error, :failed_to_parse_sdp_string}, state} | ||
| not_mdns: _ -> do_set_remote_candidate(candidate, stream_id, component_id, state) |
There was a problem hiding this comment.
Suggested change
| address_error: _ -> {:reply, {:error, :failed_to_parse_sdp_string}, state} | |
| parse_error: _ -> {:reply, {:error, :failed_to_parse_sdp_string}, state} | |
| not_mdns: _ -> do_set_remote_candidate(candidate, stream_id, component_id, state) | |
| candidate_check: _ -> {:reply, {:error, :failed_to_parse_sdp_string}, state} | |
| mdns_check: false -> do_set_remote_candidate(candidate, stream_id, component_id, state) |
mat-hek
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related with membraneframework/membrane_demo#75