Start mDNS only once per app #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
reviewed
Dec 16, 2021
lib/mdns.ex
Outdated
|
|
||
| @spec query(pid(), String.t()) :: :ok | ||
| def query(from, address) do | ||
| GenServer.cast(__MODULE__, {:query, from, address}) |
| Mdns.Client.query(address) | ||
| state = put_in(state, [:mdns_queries, address], {candidate, stream_id, component_id}) | ||
| {:reply, :ok, state} | ||
| if Application.get_env(:ex_libnice, :mdns, true) do |
There was a problem hiding this comment.
a word of docs about this would be useful
mickel8
force-pushed
the
error-msg
branch
2 times, most recently
from
0759d21
to
a2c302c
Compare
mat-hek
requested changes
Dec 20, 2021
lib/ex_libnice_app.ex
Outdated
Comment on lines
8
to
11
| ```elixir | ||
| config :ex_libnice, mdns: false | ||
| ``` | ||
| """ |
There was a problem hiding this comment.
I think that readme would be a better place for this
lib/mdns.ex
Outdated
| [from] | ||
|
|
||
| pids -> | ||
| pids ++ [from] |
There was a problem hiding this comment.
Suggested change
| pids ++ [from] | |
| [from | pids] |
lib/mdns.ex
Outdated
| end | ||
|
|
||
| @impl true | ||
| def handle_cast({:query, from, address}, state) do |
There was a problem hiding this comment.
If we're sending this, we should handle it in handle_info. Quite surprised it works this way
mickel8
force-pushed
the
error-msg
branch
3 times, most recently
from
a5c12df
to
4d4f25e
Compare
…ocs improvements. Add `ex_libnice` subdirectory.
mat-hek
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.