Add support for remote stream's decoder configuration parsing #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikWolek
suggested changes
May 25, 2023
lib/membrane_h264_plugin/parser/decoder_configuration_record.ex
Outdated
Show resolved
Hide resolved
lib/membrane_h264_plugin/parser/decoder_configuration_record.ex
Outdated
Show resolved
Hide resolved
varsill
requested changes
May 25, 2023
lib/membrane_h264_plugin/parser/decoder_configuration_record.ex
Outdated
Show resolved
Hide resolved
lib/membrane_h264_plugin/parser/decoder_configuration_record.ex
Outdated
Show resolved
Hide resolved
Qizot
force-pushed
the
decoder-configuration-record-parsing
branch
from
5b908c2
to
6014df0
Compare
varsill
approved these changes
May 31, 2023
DominikWolek
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support of parsing of the decoder configuration record that arrives in stream format, just like in
membrane_h264_ffmpeg_pluginpackage.On DCR arrival the parser will try to parse it to extract PPS and SPS values that will be prepended to the following buffer received by the parser.