Implement skip_until_keyframe? option
#35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_h264_plugin into nalu_aligned_mode
…g if the parser is working properly with that mode
…at with appropriate alignment depending on options. Add part of test checking if the valid stream format is sent
mat-hek
requested changes
Jul 10, 2023
lib/membrane_h264_plugin/parser.ex
Outdated
| Enum.reduce(aus, {[], state.au_counter, state.profile}, fn au, | ||
| {actions_acc, cnt, profile} -> | ||
| {actions, state} = | ||
| Enum.reduce(aus, {[], state}, fn au, {actions_acc, state} -> |
| end | ||
|
|
||
| state = %__MODULE__{ | ||
| scheme_parser_state: scheme_parser_state, | ||
| has_seen_keyframe?: has_seen_keyframe? |
There was a problem hiding this comment.
seems like this field should be completely removed from state
mat-hek
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
skip_until_keyframe?option:validand:errorstatuses from Membrane.H264.Parser to AUSplitterskip_until_keyframeis properly working in different scenarios, with and without parameters sent in stream