Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update load csv docstring #305

Merged
merged 7 commits into from
Jul 9, 2024
Merged

Update load csv docstring #305

merged 7 commits into from
Jul 9, 2024

Conversation

imilinovic
Copy link
Contributor

Description

Update load csv docstring about loading from remote location.

Pull request type

Please delete options that are not relevant.

  • Documentation content changes

Closes (link to issue)
closes: #264

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

######################################

Reviewer checklist (the reviewer checks this part)

  • Core feature implementation
  • Tests
  • Code documentation
  • Documentation on gqlalchemy/docs

######################################

@imilinovic imilinovic self-assigned this Feb 19, 2024
@imilinovic imilinovic added the documentation documentation label Feb 19, 2024
@imilinovic imilinovic changed the base branch from main to develop February 19, 2024 21:08
@katarinasupe katarinasupe added this to the v1.6.0 milestone Jun 5, 2024
@katarinasupe
Copy link
Contributor

katarinasupe commented Jun 24, 2024

@imilinovic We no longer use the develop branch for the release; everything goes directly to the main. Please rebase.
Also, why are there all of these changes included in your PR?

FYI, as discussed, this will be included in the next release (July 10th). Work on Memgraph is a priority, so we can move the milestone due date if you can't make it.

Note to self: update reference guide

@imilinovic imilinovic changed the base branch from develop to main July 1, 2024 06:29
@imilinovic imilinovic marked this pull request as ready for review July 1, 2024 06:30
Copy link
Contributor

@antepusic antepusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording suggestion

gqlalchemy/query_builders/memgraph_query_builder.py Outdated Show resolved Hide resolved
Co-authored-by: Ante Pušić <ante.pusic@memgraph.io>
@imilinovic imilinovic requested a review from antepusic July 1, 2024 10:42
@katarinasupe
Copy link
Contributor

@imilinovic merge the latest main for tests to pass.
Once the tests pass, feel free to squash and merge.

@imilinovic imilinovic merged commit e3f1b61 into main Jul 9, 2024
5 checks passed
@imilinovic imilinovic deleted the remote-load-csv branch July 9, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
Development

Successfully merging this pull request may close these issues.

Expand LOAD CSV with remote CSV location
4 participants