Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent Storage with Existing Claim and other improvments #26

Merged
merged 11 commits into from
Jul 3, 2024

Conversation

pamanseau
Copy link
Contributor

Added features:

  • NodeAffinity
  • ImagePullSecrets
  • version bump to 2.17
  • Added User, Password ENV
  • Added Enterprise License and Organization ENV

Variables used for persistence were changed.
Documentation not yet updated.

…p version 2.17, Added User, Password ENV, Enterprise License and Organization ENV
@pamanseau
Copy link
Contributor Author

I tested different configurations and made corrections and improvements to the helm chart
Fixed the image tag version without mage

Copy link
Collaborator

@antejavor antejavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few comments on the PR; overall, it looks ok.

I am just not sure about this existing claim, can you clarify why it is critical to have it and how do you leverage this?

Does the current setup claim the same PVC from the previous deployment if you use the same deployment name?

charts/memgraph/templates/service.yaml Outdated Show resolved Hide resolved
charts/memgraph/templates/service.yaml Outdated Show resolved Hide resolved
charts/memgraph/templates/statefulset.yaml Outdated Show resolved Hide resolved
charts/memgraph/values.yaml Outdated Show resolved Hide resolved
charts/memgraph/templates/statefulset.yaml Outdated Show resolved Hide resolved
charts/memgraph/templates/statefulset.yaml Outdated Show resolved Hide resolved
charts/memgraph/templates/statefulset.yaml Outdated Show resolved Hide resolved
charts/memgraph/templates/statefulset.yaml Outdated Show resolved Hide resolved
test-memgraph.yaml Outdated Show resolved Hide resolved
charts/memgraph/values.yaml Outdated Show resolved Hide resolved
@antejavor antejavor added this to the v0.1.4 milestone Jun 26, 2024
Copy link
Collaborator

@antejavor antejavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added features (in the end):

NodeAffinity
ImagePullSecrets
Version bump to 2.17
Added User, Password ENV
Added Enterprise License and Organization ENV
Probes (Liveliness, readiness, and startup)

@antejavor antejavor merged commit 32e7560 into memgraph:main Jul 3, 2024
2 checks passed
@pamanseau
Copy link
Contributor Author

I am just not sure about this existing claim, can you clarify why it is critical to have it and how do you leverage this?
Does the current setup claim the same PVC from the previous deployment if you use the same deployment name?

@antejavor existingClaim is used if your storage class retain the previously created PVC or you created a PVC manually (that is my case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants