-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master < ]Cache user to speed up PullPlan #1109
Conversation
Co-authored-by: gvolfing <107616712+gvolfing@users.noreply.github.com>
@andrejtonev - release note please :) |
Performance improvement when running queries with authorization turned on (with a user). |
@andrejtonev ok? Users with fine-grained privileges will experience better performance when running |
@vpavicic |
[master < Task] PR
To keep docs changelog up to date, one more thing to do:
A new FineGrainedAuthChecker is created each time a PullPlan is created. Here we called GetUser(username) which goes to disk and fetches the user data. Caching the user will help speed this up (since the user almost never changes).