[master < MG] Make mgclient compile on Ubuntu 22.04 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
June 13, 2022 19:18
antaljanosbenjamin
force-pushed
the
MG-fix-warning-on-gcc-11.4
branch
from
911eae3
to
a22160d
Compare
antaljanosbenjamin
requested review from
kostasrim,
gitbuda,
jbajic,
42jeremy and
spacejam
and removed request for
kostasrim and
gitbuda
antaljanosbenjamin
force-pushed
the
MG-fix-warning-on-gcc-11.4
branch
from
a22160d
to
2623fd1
Compare
42jeremy
approved these changes
Jun 14, 2022
antaljanosbenjamin
added a commit
that referenced
this pull request
Jun 14, 2022
This reverts commit 1cfea03.
antaljanosbenjamin
pushed a commit
that referenced
this pull request
Jun 14, 2022
* Update CI to run on Ubuntu 22.04 * Fix include order and its formatting * Make CI compiler version independent * Fix clang-format issues * Avoid deprecated low level API in OpenSSL 3.0 * Call OPENSSL_init_crypto to initialize ciphers required for RSA * Ignore warning from gmock * Parallelize compilation in CI * Ignore unknown warning option to make gmock_wrapper compile with older compilers * Restrict ingoring warnings for clang and gcc * Replace NULL by nullptr in tests * Explicitly ignore macOS for diagnostic pragma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the side I changed a lot things:
gmock/gmock.hin a header file to ignore warning coming from itNULLbynullptrin the C++ tests (for the new functions I didn't want to useNULLand also didn't want to mix the two)