Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build failed. extra semi-colon #67

Closed
msgoff opened this issue Jan 12, 2024 · 4 comments · Fixed by #68
Closed

build failed. extra semi-colon #67

msgoff opened this issue Jan 12, 2024 · 4 comments · Fixed by #68
Assignees
Labels
bug bug

Comments

@msgoff
Copy link

msgoff commented Jan 12, 2024

mgconsole/src/utils/future.hpp +276

builds fine after the semi-colon is removed

@antejavor
Copy link
Contributor

antejavor commented Jan 12, 2024

Hi @msgoff,

Thanks for pointing out this one 🙏 . We will fix it. What compiler/setup specifics did you use to build from the source?

Asking for the sake of understanding because I can see our CI/CD build is working, and it looks like an unnecessary semi-colon, but what tool/compiler is picking this?

@gitbuda gitbuda self-assigned this Jan 12, 2024
@gitbuda gitbuda added the bug bug label Jan 12, 2024
@msgoff
Copy link
Author

msgoff commented Jan 12, 2024

Hello @antejavor

Thank you for the quick response.

gcc -v
gcc version 10.2.1 20210110 (Debian 10.2.1-6)

mkdir build; cd build; cmake ..;make

[ 94%] Building CXX object src/CMakeFiles/mgconsole.dir/batch_import.cpp.o
In file included from /mgconsole/src/batch_import.cpp:26:
/mgconsole/src/utils/future.hpp:276:2: error: extra ‘;’ [-Werror=pedantic]
276 | }; // namespace utils

@gitbuda
Copy link
Member

gitbuda commented Jan 12, 2024

@msgoff the fix should be merged to master (hopefully that will help you) 💪
I think we have to improve the compile flags, but that should be done under another PR

@msgoff
Copy link
Author

msgoff commented Jan 12, 2024

@gitbuda
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants