Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing addresses field #59

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

natsoni
Copy link

@natsoni natsoni commented May 22, 2024

Fixes mempool/mempool#5079 by adding a missing addresses field to FutureBit Apollo Solo pool.

@nymkappa
Copy link
Member

I'd like the mempool backend to handle this properly regardless, for example:

  • Tags ok but missing addresses: set addresses to [] by default, log a WARN
  • Addresses ok but missing tags: set tags to [] by default, log a WARN
  • Both missing, print an ERR

Something like that..

@natsoni
Copy link
Author

natsoni commented May 23, 2024

I'd like the mempool backend to handle this properly regardless, for example:

  • Tags ok but missing addresses: set addresses to [] by default, log a WARN
  • Addresses ok but missing tags: set tags to [] by default, log a WARN
  • Both missing, print an ERR

Something like that..

Done in mempool/mempool#5098

Copy link
Member

@nymkappa nymkappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nymkappa nymkappa requested a review from softsimon May 23, 2024 13:47
@softsimon softsimon merged commit d4cfab7 into master May 23, 2024
3 checks passed
@natsoni natsoni deleted the natsoni/add-missing-addresses-field branch June 1, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pools.json import errors
3 participants